Fix clad::array copy-assignment over-reading a shorter source. - #1923
Merged
Conversation
array<T>::operator=(const array<T>&) only reallocated when the destination was smaller than the source, so a larger destination kept its old m_size and then copied that many elements from the shorter source -- a heap over-read Valgrind flags in Jacobian/Jacobian.C and Jacobian/testUtility.C once the clang false positives are suppressed. Adopt the source size before copying so the loop is bounded by the source. The buffer may exceed m_size after a shrink, which is harmless: m_size bounds every access and the destructor frees the whole buffer.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
array::operator=(const array&) only reallocated when the destination was smaller than the source, so a larger destination kept its old m_size and then copied that many elements from the shorter source -- a heap over-read Valgrind flags in Jacobian/Jacobian.C and Jacobian/testUtility.C once the clang false positives are suppressed.
Adopt the source size before copying so the loop is bounded by the source. The buffer may exceed m_size after a shrink, which is harmless: m_size bounds every access and the destructor frees the whole buffer.